Consider that the zuul executor may be an IP #2607
Merged
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! ❤️ |
pablintino
force-pushed
the
non-fqdn-zuul-executor
branch
2 times, most recently
from
ea40d7d to
ef8fa80
Compare
hjensas
requested changes
Dec 17, 2024
ci/playbooks/multinode-autohold.yml
Outdated
| {{ | ||
| zuul.executor.hostname | ||
| if (zuul.executor.hostname is ansible.utils.ip) else | ||
| (zuul.executor.hostname | split('.'))[1:] | join('.')) |
There was a problem hiding this comment.
I think the last parantheses must be removed?
AnsibleError: template error while templating string: unexpected ')'. String: {{ zuul.executor.hostname if (zuul.executor.hostname is ansible.utils.ip) else (zuul.executor.hostname | split('.'))[1:] | join('.')) }}. unexpected ')'
There was a problem hiding this comment.
Yeah, that's wrong, thanks for the correction.
Exposed a variable to pass the API endpoint without computing it too.
pablintino
force-pushed
the
non-fqdn-zuul-executor
branch
from
511d5f9 to
2fed770
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lewisdenny The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hjensas
approved these changes
Dec 19, 2024
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposed a variable to pass the API endpoint without computing it too.